test: Benchmark slowdown of element-wise list comparison#25
Open
Marius Merkle (MariusMerkleQC) wants to merge 5 commits intomainfrom
Open
test: Benchmark slowdown of element-wise list comparison#25Marius Merkle (MariusMerkleQC) wants to merge 5 commits intomainfrom
Marius Merkle (MariusMerkleQC) wants to merge 5 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 758 758
=========================================
Hits 758 758 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
Marius Merkle (MariusMerkleQC)
March 27, 2026 22:48
View session
There was a problem hiding this comment.
Pull request overview
Adds a performance-focused test to quantify the slowdown of element-wise list comparison vs eq_missing() for list columns with non-tolerance inner types, supporting follow-up optimization work around _compare_sequence_columns.
Changes:
- Import internal comparison utilities/constants needed to call
condition_equal_columns()directly. - Add a new performance regression-style test comparing
eq_missing()vs element-wise list comparison timing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marius Merkle (MariusMerkleQC)
requested review from
EgeKaraismailogluQC and
Oliver Borchert (borchero)
as code owners
| ) | ||
|
|
||
|
|
||
| def test_eq_missing_not_slower_than_field_wise_for_struct_columns() -> None: |
Collaborator
Author
There was a problem hiding this comment.
Shall I remove it again?
Marius Merkle (MariusMerkleQC)
changed the title
Marius Merkle (MariusMerkleQC)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See this comment.
Changes
Adds a benchmark test on (long) list columns (20 elements each). The column has an integer data type, so no tolerance-based comparison is necessary. We call
_compare_sequence_columnsas soon as there's a list/array anywhere in the data type tree, independent of the inner type, and this is ~5-6 times slower than using_eq_missingdirectly.